feat: allow calling InvokeEVM on accounts #1081
Conversation
Stebalien
force-pushed
the
steb/invoke-evm-account
branch
4 times, most recently
from
aab0e3c
to
fad4272
Compare
|
Context on:
We can use the codec (CBOR versus DAG_CBOR) to signal to the system whether or not reachability analysis needs to be done. CBOR is a superset of DAG_CBOR, so we're not really giving anything up here. |
Additionally, use the same dispatch mechanism for the universal receiver hook. Given #1076, CBOR encoding should no longer be a compatibility hazard for us.
Stebalien
force-pushed
the
steb/invoke-evm-account
branch
from
fad4272
to
b6aae0c
Compare
There was a problem hiding this comment.
See filecoin-project/FIPs#592 (reply in thread).
How about instead we make the built-in account always succeed for unimplemented methods. This is then open to future innovations that would otherwise require yet more special handing in the built-in account.
| } | ||
|
|
||
| impl ActorCode for EthAccountActor { | ||
| type Methods = Method; | ||
| actor_dispatch! { | ||
| Constructor => constructor, | ||
| AuthenticateMessageExported => authenticate_message, | ||
| UniversalReceiverHook => universal_receiver_hook, | ||
| UniversalReceiverHook => (), |
There was a problem hiding this comment.
Will this skip decoding the ignore parameters too (#1066)? 🎉
Could you revert this change in the tests to demonstrate this?
There was a problem hiding this comment.
Will this skip decoding the ignore parameters too (#1066)? 🎉
Yes.
Could you revert this change in the tests to demonstrate this?
Can do.
This patch introduces a few features: 1. The dispatch macro can now pass the "raw" parameters to a method. 2. The dispatch macro can now have an explicit fallback case. We then use these features to implement a "raw" fallback for both account types that simply accepts all method calls greater than the max FRC0042 number. Alternative to #1081 Fixes #1076
This patch introduces a few features: 1. The dispatch macro can now pass the "raw" parameters to a method. 2. The dispatch macro can now have an explicit fallback case. We then use these features to implement a "raw" fallback for both account types that simply accepts all method calls greater than the max FRC0042 number. Alternative to #1081 Fixes #1076
This patch introduces a few features: 1. The dispatch macro can now pass the "raw" parameters to a method. 2. The dispatch macro can now have an explicit fallback case. We then use these features to implement a "raw" fallback for both account types that simply accepts all method calls greater than the max FRC0042 number. Alternative to #1081 Fixes #1076
|
Superseded by #1086. |
Additionally, use the same dispatch mechanism for the universal receiver hook. Given #1076, CBOR encoding should no longer be a compatibility hazard for us.